Messages in this thread | | | Date | Thu, 29 Jul 2010 19:03:14 +0100 | Subject | Re: [2.6.35-rc6 patch] increase kmemleak robustness at boot | From | Daniel J Blueman <> |
| |
On 29 July 2010 16:12, Pekka Enberg <penberg@cs.helsinki.fi> wrote: > Daniel J Blueman wrote: >>> >>> I would rather change the static early alloc buffer with something >>> like bootmem allocation (the recursiveness should be bound, kmemleak >>> tracks bootmem allocations as well). But I'm on holiday until middle >>> of August and not able to do any tests in this area. >> >> Indeed, moving to dynamic early allocation is all the more better. For >> now, I'll increase the early allocation to 15200 elements, as the >> 400-entry buffer wraps 38. > > If it's just kmemleak_init() we're talking about, slab caches are up at that > point so you can just use kmalloc().
The slab allocator isn't up at this point. With CONFIG_DEBUG_KMEMLEAK_EARLY_LOG_SIZE set to 16K elements, an extra 3MB of __initdata memory is used, but freed afterwards, and it works great.
Thanks, Daniel -- Daniel J Blueman
| |