Messages in this thread | | | Date | Wed, 28 Jul 2010 15:31:16 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 2/2] s6e63m0: fix section mismatch |
| |
On Wed, 28 Jul 2010 11:07:36 +0800 Axel Lin <axel.lin@gmail.com> wrote:
> Eliminate section mismatch warning by marking s6e63m0_probe() as __devinit. >
Please aways quote the error messages or warnings when fixing build errors or warnings. It helps with the review quite a lot.
> > diff --git a/drivers/video/backlight/s6e63m0.c b/drivers/video/backlight/s6e63m0.c > index b27ccf9..1757379 100644 > --- a/drivers/video/backlight/s6e63m0.c > +++ b/drivers/video/backlight/s6e63m0.c > @@ -732,7 +732,7 @@ static ssize_t s6e63m0_sysfs_show_gamma_table(struct device *dev, > static DEVICE_ATTR(gamma_table, 0644, > s6e63m0_sysfs_show_gamma_table, NULL); > > -static int __init s6e63m0_probe(struct spi_device *spi) > +static int __devinit s6e63m0_probe(struct spi_device *spi) > { > int ret = 0; > struct s6e63m0 *lcd = NULL;
Many drivers/video/backlight/*.c drivers use __devinit for the platform_driver.probe handler. Quite a lot use nothing (ie: .text). Some still use __init. About half of them use __devexit_p for .remove and half don't. It looks like it all needs a bit of loving care.
| |