lkml.org 
[lkml]   [2010]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 04/10] x86: mce: fix error handling

> I'm agree with you that if allocation fails at boot time, we are dead :)
> But this coding style breaking rules that result from some functions
> _must_ be checked for errors. Maybe we should add BUG_ON() here or
> indicate someway that we have no ideas how to handle error?

What rules exactly? I don't think any of those functions are declared
with __must_check

Coding style should never get in the way of what is right.

The classic way to explicitely discard a return value is a cast to void,
but that is generally considered
ugly in the Linux kernel.

One could possibly add a comment about this at least.

-Andi



\
 
 \ /
  Last update: 2010-07-28 19:23    [W:0.076 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site