Messages in this thread | | | Date | Wed, 28 Jul 2010 19:20:11 +0200 | From | Andi Kleen <> | Subject | Re: [PATCH 04/10] x86: mce: fix error handling |
| |
> I'm agree with you that if allocation fails at boot time, we are dead :) > But this coding style breaking rules that result from some functions > _must_ be checked for errors. Maybe we should add BUG_ON() here or > indicate someway that we have no ideas how to handle error?
What rules exactly? I don't think any of those functions are declared with __must_check
Coding style should never get in the way of what is right.
The classic way to explicitely discard a return value is a cast to void, but that is generally considered ugly in the Linux kernel.
One could possibly add a comment about this at least.
-Andi
| |