Messages in this thread | | | Subject | Re: [PATCH 28/31] memblock: Export MEMBLOCK_ERROR again | From | Benjamin Herrenschmidt <> | Date | Wed, 28 Jul 2010 19:29:02 +1000 |
| |
On Tue, 2010-07-27 at 23:13 -0700, Yinghai Lu wrote: > So still keep MEMBLOCK_ERROR to (~(phys_addr_t)0) ?
No point for now. lmb_alloc() etc... are defined as returning 0 for failure so we would need to fix that too.
As I said in a previous email we do need to revisit the memblock error handling.
> We can change some variable from unsigned long to phys_addr_t that > will be assigned by memblock_find_base(). > > that could avoid casting too.
That would be a good idea anyways if those are indeed carrying a physical address.
Ben.
| |