Messages in this thread | | | Date | Mon, 26 Jul 2010 21:41:07 -0700 | From | Yinghai Lu <> | Subject | Re: [PATCH] ipmi: Fix memleaking for add_smi when duplicating happen |
| |
On 07/26/2010 07:05 PM, Corey Minyard wrote: > Please run this through checkpatch, as it has coding style violations.
yhlu@linux-siqj:~/xx/xx/kernel/tip/linux-2.6> ./scripts/checkpatch.pl patches/ipmi_reg_size.patch total: 0 errors, 0 warnings, 105 lines checked
patches/ipmi_reg_size.patch has no obvious style problems and is ready for submission. yhlu@linux-siqj:~/xx/xx/kernel/tip/linux-2.6>
> > Also, this patch appears to fix bugs in addition to adding the print. > Can we have a separate patch for that?
in the comment log, i already mentioned that.
will separate it to twol
> > I'm also not clear on the reason for this. I believe all this > information is already available in /proc/ipmi/<if#>/params. I don't > think there is a strong reason to print it to the log.
then why there is printing for ACPI path and pci path?
Yinghai
| |