Messages in this thread | | | Subject | Re: [PATCH net-next] drivers/net/vxge: Use pr_<level>, fix logging macros | From | Joe Perches <> | Date | Tue, 27 Jul 2010 14:43:35 -0700 |
| |
On Tue, 2010-07-27 at 16:38 -0500, Jon Mason wrote: > On Tue, Jul 27, 2010 at 01:43:08PM -0700, Joe Perches wrote: > > Use direct printing of logging messages to save text. > I have a similar patch queued internally (pending testing).
Great.
[]
> Why not make the entire vxge_debug part of vxge_debug_ll? If > disabled, that code can be removed completely as it is unnecessary. > Also, why not call printk directly from vxge_debug? This code had too > many levels of indirection before, remove all of them (as that is way > I did in the internal patch).
'cause I don't really want to figure out the nesting, I just want it to be smaller and easier to understand.
> I did not have any of these changes in my patch. If you want to push > this seperately, I ack it.
I'll resend separately.
cheers, Joe
| |