Messages in this thread | | | From | Kay Sievers <> | Date | Mon, 26 Jul 2010 11:12:08 +0200 | Subject | Re: [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on |
| |
On Mon, Jul 26, 2010 at 11:08, Dhaval Giani <dhaval.lists@thegianis.in> wrote: > On Thu, Jul 22, 2010 at 8:36 PM, Greg KH <gregkh@suse.de> wrote: >> On Thu, Jul 22, 2010 at 11:31:07AM -0700, Paul Menage wrote: >>> On Thu, Jul 22, 2010 at 11:26 AM, Greg KH <gregkh@suse.de> wrote: >>> > We really shouldn't be asking userspace to create new root filesystems. >>> > So follow along with all of the other in-kernel filesystems, and provide >>> > a mount point in sysfs. >>> > >>> > For cgroupfs, this should be in /sys/fs/cgroup/ This change provides >>> > that mount point when the cgroup filesystem is registered in the kernel. >>> >>> But cgroups will typically have multiple mounts, with different >>> resource controllers/options on each mount. That doesn't really fit in >>> with this scheme. >> >> Really? I see systems mounting it at /cgroups/ in the filesystem today. >> Where are you expecting it to be mounted at? >> > > Not really. It is getting mounted at /cgroups/<name of resource > controller>/ at a number of places. Keeping it in sysfs loses us a lot > of this flexibility. Unless you are ready to keep adding a new > mountpoint for each subsystem, it will not really work out in the long > term.
As mentioned earlier in this thread, systemd already mounts a tmpfs at the cgroup mountpoint. We need only a single directory. This should not be an issue.
Kay -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |