lkml.org 
[lkml]   [2010]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [ath5k-devel] [PATCH v3] ath5k: disable ASPM
    On Mon, Jul 26, 2010 at 01:13:22PM -0700, Luis R. Rodriguez wrote:
    > On Sat, Jun 19, 2010 at 08:32:44AM -0700, Maxim Levitsky wrote:
    > > On Sat, 2010-06-19 at 16:02 +0300, Maxim Levitsky wrote:
    > > > On Sat, 2010-06-19 at 08:38 -0400, Bob Copeland wrote:
    > > > > On Sat, Jun 19, 2010 at 10:49:34AM +0300, Maxim Levitsky wrote:
    > > > > > How this patch?
    > > > >
    > > > > Looks fine to me. Some nitpicking below but feel free to add my
    > > > >
    > > > > Acked-by: Bob Copeland <me@bobcopeland.com>
    > > > >
    > > Done.
    > >
    > > Best regards,
    > > Maxim Levitsky
    > >
    > > ---
    > >
    > > commit 616afa397b3e843f2aba06be12a30e72dfff7740
    > > Author: Maxim Levitsky <maximlevitsky@gmail.com>
    > > Date: Thu Jun 17 23:21:42 2010 +0300
    > >
    > > ath5k: disable ASPM
    > >
    > > Atheros card on Acer Aspire One (AOA150, Atheros Communications Inc. AR5001
    > > Wireless Network Adapter [168c:001c] (rev 01)) doesn't work well with ASPM
    > > enabled. With ASPM ath5k will eventually stall on heavy traffic with often
    > > 'unsupported jumbo' warnings appearing. Disabling ASPM L0s in ath5k fixes
    > > these problems.
    > > Also card sends a storm of RXORN interrupts even though medium is idle.
    > >
    > > Reproduced with pcie_aspm=force and by using 'nc < /dev/zero > /dev/null' at
    > > both ends (usually stalls within seconds).
    > >
    > > Unfortunately BIOS enables ASPM on this card by default on these machines
    > > This means that, problem shows up (less often) without pcie_aspm=force too.
    > > Therefore to benefit from this fix you need to _enable_ CONFIG_PCIEASPM
    > >
    > >
    > > All credit for this patch goes to Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
    > > for finding and fixing this bug.
    > >
    > > Based on patch that is
    > > From: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
    > >
    > >
    > > Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com>
    > > Acked-by: Bob Copeland <me@bobcopeland.com>
    >
    > Acked-by: Luis R. Rodriguez <lrodriguez@atheros.com>

    So NACK now, to really fix this correctly its best to instead disable L0s but
    to force enable also L1 if the device is a PCI Express device. All Atheros legacy
    devices (ath5k) should work correctly with L1. Kernels with CONFIG_PCIEASPM
    would end up disabling even L1 for pre PCI 1.1 devices.

    Luis


    \
     
     \ /
      Last update: 2010-07-27 00:59    [W:0.024 / U:0.196 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site