Messages in this thread | | | Date | Mon, 26 Jul 2010 15:34:40 -0700 | From | Greg KH <> | Subject | Re: [PATCH v2] Staging: dt3155: make local variables static |
| |
On Fri, Jul 23, 2010 at 01:03:34PM -0700, H Hartley Sweeten wrote: > The symbols dt3155_dev_open, unique_tag, and allocatorAddr are only used in > the file dt3155_drv.c and should be static. Also, as pointed out by Joe Perches, > static variables do not need initialization so remove them. While here, also > move the definition for allocatorAddr so that all the variables are declared at > one place in the code.
This doesn't apply after applying your previous patch to this file :(
thanks,
greg k-h
| |