lkml.org 
[lkml]   [2010]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [ath5k-devel] [PATCH v3] ath5k: disable ASPM
    On Mon, Jul 26, 2010 at 2:25 PM, Matthew Garrett <mjg59@srcf.ucam.org> wrote:
    > On Tue, Jul 27, 2010 at 12:17:13AM +0300, Maxim Levitsky wrote:
    >
    >> However, it is possible, (and that what I asked you) that some ath5k
    >> devices aren't 'pre 1.1 pcie devices' so linux won't disable ASPM L0s
    >> for them.
    >> So indeed for 'good feeling' it is ok to disable L0s from ath5k
    >> explicitly, but most of the time (or always) it will be no-op.
    >>
    >> In *addition* to that, since you said that ASPM L1 *does* work, and is
    >> enabled by BIOS, but linux disables it, that it might be worthy to
    >> enable it again from ath5k driver explicitly.
    >> As long as wireless works I don't really care if this done or not.
    >
    > This may need to be done on a chip by chip basis. Take a look at
    > http://www.atheros.cz/inffile.php?inf=68&bit=32&atheros=AR5002G&system=4
    > and some of the other inf files on that site to see which devices
    > provide the PciASPMOptIn flag - those should support ASPM states even if
    > they're pre-1.1 devices.

    I rather we not bother with these, lets simply follow the kernel's
    lead here for its rule matching.

    Luis


    \
     
     \ /
      Last update: 2010-07-27 00:19    [W:0.038 / U:212.108 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site