Messages in this thread |  | | | Date | Mon, 26 Jul 2010 18:42:06 +0200 | | From | Robert Richter <> | | Subject | Re: [PATCH 6/7] x86, xsave: disable xsave in i387 emulation mode |
| |
On 23.07.10 13:50:05, Suresh Siddha wrote:
> Then the more appropriate place for this is to check at the beginning of > the xsave init code.
No it isn't, HAVE_HWFP is an fpu implementation and the soft fpu check would be duplicate in xsave.c. Also, the HAVE_HWFP macro is local in i387.c and would have to be exported in a header file then, which somehow taints the api.
So I rather tend to this patch than implementing fpu code in xsave for a small or no benefit.
-Robert
-- Advanced Micro Devices, Inc. Operating System Research Center
|  |