lkml.org 
[lkml]   [2010]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] PCI: MSI: Restore read_msi_msg_desc(); add get_cached_msi_msg_desc()
    From
    Date
    On Fri, 2010-07-23 at 14:56 +0100, Ben Hutchings wrote:
    > commit 2ca1af9aa3285c6a5f103ed31ad09f7399fc65d7 "PCI: MSI: Remove
    > unsafe and unnecessary hardware access" changed read_msi_msg_desc() to
    > return the last MSI message written instead of reading it from the
    > device, since it may be called while the device is in a reduced
    > power state.
    >
    > However, the pSeries platform code really does need to read messages
    > from the device, since they are initially written by firmware.
    > Therefore:
    > - Restore the previous behaviour of read_msi_msg_desc()
    > - Add new functions get_cached_msi_msg{,_desc}() which return the
    > last MSI message written
    > - Use the new functions where appropriate
    >
    > Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>

    Looks good to me.

    cheers

    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2010-07-26 13:23    [W:0.020 / U:29.688 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site