lkml.org 
[lkml]   [2010]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCHv5 13/15] writeback: remove unnecessary init_timer call
    Date
    From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>

    The 'setup_timer()' function also calls 'init_timer()', so the extra
    'init_timer()' call is not needed. Indeed, 'setup_timer()' is basically
    'init_timer()' plus callback function and data pointers initialization.

    Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
    Reviewed-by: Christoph Hellwig <hch@lst.de>
    ---
    mm/backing-dev.c | 1 -
    1 files changed, 0 insertions(+), 1 deletions(-)

    diff --git a/mm/backing-dev.c b/mm/backing-dev.c
    index c2def00..7cef95e 100644
    --- a/mm/backing-dev.c
    +++ b/mm/backing-dev.c
    @@ -236,7 +236,6 @@ static int __init default_bdi_init(void)
    sync_supers_tsk = kthread_run(bdi_sync_supers, NULL, "sync_supers");
    BUG_ON(IS_ERR(sync_supers_tsk));

    - init_timer(&sync_supers_timer);
    setup_timer(&sync_supers_timer, sync_supers_timer_fn, 0);
    bdi_arm_supers_timer();

    --
    1.7.1.1


    \
     
     \ /
      Last update: 2010-07-25 10:35    [W:0.023 / U:149.936 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site