lkml.org 
[lkml]   [2010]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: linux-next: OOPS at boot time
    On Fri, Jul 23, 2010 at 12:04:08PM +0200, Jan Kara wrote:

    > > @@ -1428,8 +1429,10 @@ out:
    > > /*
    > > * Undo the block allocation
    > > */
    > > - if (!performed_allocation)
    > > - dquot_free_block(inode, *count);
    > > + if (!performed_allocation) {
    > > + dquot_free_block_nodirty(inode, *count);
    > > + mark_inode_dirty(inode);
    > > + }
    > > brelse(bitmap_bh);
    > > return 0;
    > > }
    > Sorry, but the above two changes look stupid... Why call _nodirty variant
    > and dirty the inode immediately after that? It happens in two other places
    > in your patch as well...

    Frankly, I don't believe that dquot_free_block() is _ever_ the right interface;
    please, leave dirtying the inode to the filesystem and let it be explicit.


    \
     
     \ /
      Last update: 2010-07-24 14:31    [W:0.020 / U:59.412 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site