lkml.org 
[lkml]   [2010]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv4 14/14] writeback: add new tracepoints
On Fri, Jul 23, 2010 at 06:05:54PM +0300, Artem Bityutskiy wrote:
> From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
>
> Add 2 new trace points to the periodic write-back wake up case, just like we do
> in the 'bdi_queue_work()' function. Namely, introduce:
>
> 1. trace_writeback_wakeup(bdi)
> 2. trace_writeback_wakeup_nothread(bdi)
>
> The first event is triggered every time we wake up a bdi thread to start
> periodic background write-out. The second event is triggered only when the bdi
> thread does not exist and should be created by the forker thread.
>
> This patch was suggested by Dave Chinner <david@fromorbit.com>

As mentioned before doing the wakeup just for the case where we
really wake up the flusher thead is much better. It's not 100%
clear for bdi_queue_work as we queue the work in either case, but
I'd prefer to fix that one up as well (not in your series anyway)



\
 
 \ /
  Last update: 2010-07-23 18:31    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site