Messages in this thread | | | Date | Thu, 22 Jul 2010 16:39:16 -0700 | From | Greg KH <> | Subject | Re: [PATCH 1/6] Driver core: Fix potential memory leak |
| |
On Thu, Jul 22, 2010 at 03:09:01PM -0700, Patrick Pannuto wrote: > In both of the 'goto out' cases, priv has already > been allocated and assigned to bus->p. We reset > bus->p to NULL, but neglect to free bus->p > > Signed-off-by: Patrick Pannuto <ppannuto@codeaurora.org> > --- > drivers/base/bus.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/base/bus.c b/drivers/base/bus.c > index 12eec3f..eb1b7fa 100644 > --- a/drivers/base/bus.c > +++ b/drivers/base/bus.c > @@ -945,8 +945,8 @@ bus_devices_fail: > bus_remove_file(bus, &bus_attr_uevent); > bus_uevent_fail: > kset_unregister(&bus->p->subsys); > - kfree(bus->p); > out: > + kfree(bus->p);
This fix is already in my tree.
thanks,
greg k-h
| |