Messages in this thread |  | | | Date | Thu, 22 Jul 2010 11:47:57 -0700 | | From | Greg KH <> | | Subject | Re: [PATCH] Staging: comedi: drivers: Code style issues |
| |
On Thu, Jul 22, 2010 at 01:07:53PM -0400, Chihau Chau wrote: > From: Chihau Chau <chihau@gmail.com> > > This fix some lines over 80 characters. > > Signed-off-by: Chihau Chau <chihau@gmail.com> > --- > drivers/staging/comedi/drivers.c | 17 ++++++++--------- > 1 files changed, 8 insertions(+), 9 deletions(-) > > diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c > index 4a29ed7..50c8295 100644 > --- a/drivers/staging/comedi/drivers.c > +++ b/drivers/staging/comedi/drivers.c > @@ -117,8 +117,8 @@ int comedi_device_attach(struct comedi_device *dev, struct comedi_devconfig *it) > > for (driv = comedi_drivers; driv; driv = driv->next) { > if (!try_module_get(driv->module)) { > - printk > - (KERN_INFO "comedi: failed to increment module count, skipping\n"); > + printk(KERN_INFO "comedi: failed to increment module " > + "count, skipping\n");
No, please don't break strings across lines like this, it makes it harder to grep for things.
How about something like: printk(KERN_INFO "comedi: failed to increment module count, skipping\n"); instead. That should pass the checkpatch.pl script, right?
thanks,
greg k-h
|  |