lkml.org 
[lkml]   [2010]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateThu, 22 Jul 2010 01:49:57 -0400
FromChristoph Hellwig <>
SubjectRe: [BUG] ext4 trace events cause NULL pointer dereferences
On Wed, Jul 21, 2010 at 10:31:20PM +0900, KOSAKI Motohiro wrote:
> But, I don't think this is proper fix because we don't want any overhead
> if the tracepoint is disabled.
>
> So, How do we check NULL in TP_fast_assign()?

I think ext4 is simply using an incorrectly typed tracepoint here.
If you want it to be useful in any way it needs a sb paramter and
an optional inode paramter, not the allocation context.

Also the whole ext4_mb_release_group_pa function seems to be a bit
misdesigned. The code using ac is a totally separate block at the
end of the function and does work that's unrelated to the rest
of the function. Just making it a separate helper can calling it
only from those places that have the allocation context would make
the code more clear.


\
 
 \ /
  Last update: 2010-07-22 07:53    [from the cache]
©2003-2010