Messages in this thread | | | Date | Thu, 22 Jul 2010 11:06:24 +0530 | From | Balbir Singh <> | Subject | Re: [PATCH 3/7] memcg: nid and zid can be calculated from zone |
| |
* KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> [2010-07-21 22:33:56]:
> > > +static inline int zone_nid(struct zone *zone) > > > +{ > > > + return zone->zone_pgdat->node_id; > > > +} > > > + > > > > hmm, adding a helper and not converting the existing users of > > zone->zone_pgdat may be a little confusing particularly as both types of > > usage would exist in the same file e.g. in mem_cgroup_zone_nr_pages. > > I see. here is incrementa patch. > > Thanks > > From 62cf765251af257c98fc92a58215d101d200e7ef Mon Sep 17 00:00:00 2001 > From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> > Date: Tue, 20 Jul 2010 11:30:14 +0900 > Subject: [PATCH] memcg: convert to zone_nid() from bare zone->zone_pgdat->node_id > > Now, we have zone_nid(). this patch convert all existing users of > zone->zone_pgdat. > > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> > --- > mm/memcontrol.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 82e191f..3d5b645 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -951,7 +951,7 @@ unsigned long mem_cgroup_zone_nr_pages(struct mem_cgroup *memcg, > struct zone *zone, > enum lru_list lru) > { > - int nid = zone->zone_pgdat->node_id; > + int nid = zone_nid(zone); > int zid = zone_idx(zone); > struct mem_cgroup_per_zone *mz = mem_cgroup_zoneinfo(memcg, nid, zid); > > @@ -961,7 +961,7 @@ unsigned long mem_cgroup_zone_nr_pages(struct mem_cgroup *memcg, > struct zone_reclaim_stat *mem_cgroup_get_reclaim_stat(struct mem_cgroup *memcg, > struct zone *zone) > { > - int nid = zone->zone_pgdat->node_id; > + int nid = zone_nid(zone); > int zid = zone_idx(zone); > struct mem_cgroup_per_zone *mz = mem_cgroup_zoneinfo(memcg, nid, zid); > > @@ -1006,7 +1006,7 @@ unsigned long mem_cgroup_isolate_pages(unsigned long nr_to_scan, > LIST_HEAD(pc_list); > struct list_head *src; > struct page_cgroup *pc, *tmp; > - int nid = z->zone_pgdat->node_id; > + int nid = zone_nid(z); > int zid = zone_idx(z); > struct mem_cgroup_per_zone *mz; > int lru = LRU_FILE * file + active;
Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com>
-- Three Cheers, Balbir
| |