lkml.org 
[lkml]   [2010]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH 1/3] DMAENGINE: generic slave channel control v2
> 2010/7/22 Linus Walleij <linus.walleij@stericsson.com>:
>
> > This adds an interface to the DMAengine to make it possible to
> > reconfigure a slave channel at runtime. We add a few foreseen
> > config parameters to the passed struct, with a void * pointer
> > for custom per-device or per-platform runtime slave data.
>
> BTW Vinod, if you're happy with this API, then please ACK it so
> Dan has some indication whether it'll fit the Moorestown too.

Shouldn't this patch remove the private member in dma_chan structure

Currently chan->private is used for sending slave or similar channel specific
information. Now if we want to add struct dma_slave_config, then IMHO it
would make sense to remove private variable and replace with dma_slave_config
struture. That way we can reuse this struture there as well and if someone wants
to add more stuff he can use the private_config.

Dan, what do you think about this?

Thanks
-Vinod


\
 
 \ /
  Last update: 2010-07-22 18:15    [from the cache]
©2003-2011 Jasper Spaans