Messages in this thread |  | | | Date | Thu, 22 Jul 2010 11:01:13 +0530 | | From | Balbir Singh <> | | Subject | Re: [PATCH 1/7] memcg: sc.nr_to_reclaim should be initialized |
| |
* KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> [2010-07-16 19:13:31]:
> Currently, mem_cgroup_shrink_node_zone() initialize sc.nr_to_reclaim as 0. > It mean shrink_zone() only scan 32 pages and immediately return even if > it doesn't reclaim any pages. > > This patch fixes it. > > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> > --- > mm/vmscan.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 1691ad0..bd1d035 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1932,6 +1932,7 @@ unsigned long mem_cgroup_shrink_node_zone(struct mem_cgroup *mem, > struct zone *zone, int nid) > { > struct scan_control sc = { > + .nr_to_reclaim = SWAP_CLUSTER_MAX, > .may_writepage = !laptop_mode, > .may_unmap = 1, > .may_swap = !noswap,
Could you please do some additional testing on
1. How far does this push pages (in terms of when limit is hit)? 2. Did you hit a problem with the current setting or is it a review fix?
-- Three Cheers, Balbir
|  |