lkml.org 
[lkml]   [2010]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] md: bitwise operations might not fit in a "bool"
On 07/22/2010 02:55 PM, Neil Brown wrote:
> On Thu, 22 Jul 2010 14:44:53 +0300
> Boaz Harrosh <bharrosh@panasas.com> wrote:
>
>>
>> when taking a resolute of a bit-wise AND as true false. Better / faster
>> to make it a boolean operation.
>>
>> This fixes a bug and a crash because the flags field did not fit into
>> the bool operands.
>
> No, that won't work.
> Read the rest of the code and see where 'do_sync' and 'do_barriers' are used.
>
> NeilBrown
>

You are right! (I didn't look)

the use of "bool" was wrong from the get go. it was never a bool operation.
What was the guy thinking? What is that do_XXX name? that name should change
as well. Perhaps flg_sync, flg_barriers.

Boaz


\
 
 \ /
  Last update: 2010-07-22 14:23    [from the cache]
©2003-2011 Jasper Spaans