Messages in this thread |  | | | Date | Wed, 21 Jul 2010 08:02:50 -0400 | | From | Christoph Hellwig <> | | Subject | Re: [PATCHv2 09/11] writeback: restructure bdi forker loop a little |
| |
On Wed, Jul 21, 2010 at 12:31:44PM +0300, Artem Bityutskiy wrote: > From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com> > > This patch re-structures the loop which walks bdi a little. This is just a > micro-step towards the coming change where the forker thread will kill the bdi > threads. It should simplify reviewing the following changes, which would > otherwise be larger. > > This patch also adds the 'bdi_cap_flush_forker(bdi)' condition check to the > loop. The reason for this is that the forker thread can start _before_ the > 'BDI_registered' flag is set (see 'bdi_register()'), so the WARN() statement > will fire for the default bdi. I observed this warning at boot-up. > > This patch also amends comments a little.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
|  |