lkml.org 
[lkml]   [2010]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/6] writeback: avoid unnecessary calculation of bdi dirty thresholds
    On Tue, 20 Jul 2010 11:34:37 +0800 Wu Fengguang <fengguang.wu@intel.com> wrote:

    > On Tue, Jul 20, 2010 at 05:35:20AM +0800, Andrew Morton wrote:
    > > On Sun, 11 Jul 2010 10:06:59 +0800
    > > Wu Fengguang <fengguang.wu@intel.com> wrote:
    > >
    > > > Split get_dirty_limits() into global_dirty_limits()+bdi_dirty_limit(),
    > > > so that the latter can be avoided when under global dirty background
    > > > threshold (which is the normal state for most systems).
    > > >
    > >
    > > mm/page-writeback.c: In function 'balance_dirty_pages_ratelimited_nr':
    > > mm/page-writeback.c:466: warning: 'dirty_exceeded' may be used uninitialized in this function
    > >
    > > This was a real bug.
    >
    > Thanks! But how do you catch this? There are no warnings in my compile test.

    Basic `make allmodconfig'. But I use a range of different compiler
    versions. Different versions of gcc detect different stuff. This was 4.1.0
    or 4.0.2, I forget which.




    \
     
     \ /
      Last update: 2010-07-20 06:17    [W:0.019 / U:104.808 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site