Messages in this thread | | | Date | Tue, 20 Jul 2010 23:27:17 +0400 | From | Cyrill Gorcunov <> | Subject | Re: [PATCH 00/10] x86, xsave: some code cleanups and reworks |
| |
On Tue, Jul 20, 2010 at 08:50:47PM +0200, Robert Richter wrote: > > This patch series contains some cleanups and reworks I made during > code review and feature implementation for upcoming cpus. > > Most patches refactor the xsave initialization that is very dependent > on fpu initialization. This series starts to decouple this a little > bit as xsave not only supports fpu features. Also this is an attempt > to ease the xsave interface by making some of the functions and > variables static. > > There is also one patch that removes boot_cpu_id variable, which is > not really related to xsave. Maybe this should be applied to another > branch. > > The patches are relative to today's tip/x86/xsave branch. > > (The patches are small for better review and rebasing.) > > -Robert >
Hi Robert, I recall there was a thread related to boot_cpu_id and cpu = 0. Unfortunately I can't find it neither in my mbox nor somewhere in net at moment. Ie technically speaking -- yes boot_cpu_id will be 0 but perhaps instead of magic !cpu and friends explicit boot_cpu_id might be better for code reading. It might be is_boot_cpu() macro helper or so as well.
Though I don't have strong opinion but for ones who will be reading the code first time it might be confusing :) Agreed?
-- Cyrill
| |