lkml.org 
[lkml]   [2010]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCHv3 1/3] USB: gadget: mass/file storage: set serial number
    On Tue, 20 Jul 2010, [utf-8] Michał Nazarewicz wrote:

    > > On Mon, 19 Jul 2010, [utf-8] Michal‚ Nazarewicz wrote:
    > >> 1/3: http://lkml.org/lkml/2010/7/8/317
    > >> Adds serial to mass storage gadget and g_multi introducing
    > >> fsg_string_serial_fill() macro used by abovementioned
    > >> gadgets and file storage gadget.
    >
    > On Mon, 19 Jul 2010 19:06:32 +0200, Alan Stern <stern@rowland.harvard.edu> wrote:
    > > Ah, yes. My personal taste would be to write fsg_string_serial_fill_n
    > > as an inline routine instead of as a macro, and not try to make it
    > > separate from fsg_string_serial_fill.
    >
    > Not sure what you meant by "make it separate from fsg_string_serial_fill".

    I mean have a single function, called "fsg_string_serial_fill", instead
    of two separate macros called "fsg_string_serial_fill" and
    "fsg_string_serial_fill_n".

    Alan Stern

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-07-20 16:11    [W:4.521 / U:0.176 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site