Messages in this thread | | | Date | Fri, 02 Jul 2010 09:53:35 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH 0/2] use q->prep_rq_fn for flush requests instead of q->prepare_flush_fn() |
| |
On 2010-07-02 09:52, Christoph Hellwig wrote: > On Fri, Jul 02, 2010 at 04:33:23PM +0900, FUJITA Tomonori wrote: >> We could kill q->prepare_flush_fn(). Except for ide, all the users >> just mark flush requests. They can use REQ_FLUSH flag instead. Ide can >> do like SCSI. > > Yes, and I think you should go all the way to kill it instead of > keeping both APIs around. Otherwise the patchset looks good to me.
Fully agree, lets get rid of ->prepare_flush_fn().
-- Jens Axboe
| |