Messages in this thread | | | Date | Fri, 2 Jul 2010 16:13:46 -0700 | From | Jesse Barnes <> | Subject | Re: [PATCH] PCI: Default PCIe ASPM control to on and require !EMBEDDED to disable |
| |
On Tue, 22 Jun 2010 17:03:03 -0400 Matthew Garrett <mjg@redhat.com> wrote:
> The CONFIG_PCIEASPM option is confusing and potentially dangerous. ASPM is > a hardware mediated feature rather than one under direct OS control, and > even if the config option is disabled the system firmware may have turned > on ASPM on various bits of hardware. This can cause problems later - > various hardware that claims to support ASPM does a poor job of it and may > hang or cause other difficulties. The kernel is able to recognise this in > many cases and disable the ASPM functionality, but only if CONFIG_PCIEASPM > is enabled. > > Given that in its default configuration this option will either leave the > hardware as it was originally or disable hardware functionality that may > cause problems, it should by default y. The only reason to disable it > ought to be to reduce code size, so make it dependent on CONFIG_EMBEDDED. > > Signed-off-by: Matthew Garrett <mjg@redhat.com> > Cc: lrodriguez@atheros.com > Cc: maximlevitsky@gmail.com > --- > drivers/pci/pcie/Kconfig | 20 ++++++++++++++------ > 1 files changed, 14 insertions(+), 6 deletions(-) >
Applied to my linux-next branch, thanks.
-- Jesse Barnes, Intel Open Source Technology Center
| |