Messages in this thread | | | Date | Fri, 2 Jul 2010 10:05:28 -0400 | From | Christoph Hellwig <> | Subject | Re: Race in wb_do_writeback() ??? |
| |
Jens, I think we need to pull this patch into 2.6.35 still. While we could fix the various races with the kfree and wakeup vs ->state manipulation in a slightly smaller way at least this patch has gotten lots of testing in linux-next and targeted stress testing.
On Tue, Jun 29, 2010 at 04:26:50PM -0400, Christoph Hellwig wrote: > On Tue, Jun 29, 2010 at 04:28:16PM -0400, Larry Woodman wrote: > > Can you have one unconditional call to wb_clear_pending() after the > > calling wb_writeback()??? > > In fact we should only have a conditional call after wb_writeback. > I've done that already and it's in Jens' tree for 2.6.36: > > http://git.kernel.dk/?p=linux-2.6-block.git;a=commitdiff;h=79338d2a78ab78efdc1698f1309766a039addf9d > ---end quoted text---
| |