[lkml]   [2010]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCHv3 1/3] USB: gadget: mass/file storage: set serial number

    >   It in no way duplicates functionality of
    > the composite layer.

    Beyond the obvious "Set serial number" ...

    > As a matter of fact, without
    > this patch, the
    > iSerialNumber module parameter won't work

    So submit a bugfix for that alone, making it
    work everywhere...

    > (not tested, just looked at the code).

    Do you know when it broke? That code has been
    tested in the past, and observed to work. So if
    it's not working now, someone broke it and that
    should just be fixed.

    > The second patch (by Yann Cantin) adds a serial module
    > parameter to
    > the File Storage Gadget.  FSG is not a composite
    > gadget

    OK, so it should add a module param with the same
    name as used elsewhere ... makes sense to me. If
    Alan Acks that patch, go for it.

    - Dave

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2010-07-19 12:11    [W:0.021 / U:0.152 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site