Messages in this thread Patch in this message |  | | | Date | Mon, 19 Jul 2010 14:35:20 -0700 | | From | Andrew Morton <> | | Subject | Re: [PATCH 3/6] writeback: avoid unnecessary calculation of bdi dirty thresholds |
| |
On Sun, 11 Jul 2010 10:06:59 +0800 Wu Fengguang <fengguang.wu@intel.com> wrote:
> Split get_dirty_limits() into global_dirty_limits()+bdi_dirty_limit(), > so that the latter can be avoided when under global dirty background > threshold (which is the normal state for most systems). >
mm/page-writeback.c: In function 'balance_dirty_pages_ratelimited_nr': mm/page-writeback.c:466: warning: 'dirty_exceeded' may be used uninitialized in this function
This was a real bug.
--- a/mm/page-writeback.c~writeback-avoid-unnecessary-calculation-of-bdi-dirty-thresholds-fix +++ a/mm/page-writeback.c @@ -463,7 +463,7 @@ static void balance_dirty_pages(struct a unsigned long bdi_thresh; unsigned long pages_written = 0; unsigned long pause = 1; - int dirty_exceeded; + bool dirty_exceeded = false; struct backing_dev_info *bdi = mapping->backing_dev_info; for (;;) { _
|  |