lkml.org 
[lkml]   [2010]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [S+Q2 07/19] slub: Allow removal of slab caches during boot
From
Date
On Wed, 2010-07-14 at 16:48 -0700, David Rientjes wrote:
> On Fri, 9 Jul 2010, Christoph Lameter wrote:
>
> > If a slab cache is removed before we have setup sysfs then simply skip over
> > the sysfs handling.
> >
> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > Cc: Roland Dreier <rdreier@cisco.com>
> > Signed-off-by: Christoph Lameter <cl@linux-foundation.org>
>
> Acked-by: David Rientjes <rientjes@google.com>
>
> I missed this case earlier because I didn't consider slab caches being
> created and destroyed prior to slab_state == SYSFS, sorry!

Ok so I may be a bit sleepy or something but I still fail to see how
this whole thing isn't totally racy...

AFAIK. By the time we switch the slab state, we -do- have all CPUs up
and can race happily between creating slab caches and creating the sysfs
files...

Ben.




\
 
 \ /
  Last update: 2010-07-19 02:11    [W:0.227 / U:0.420 seconds]
©2003-2014 Jasper Spaans. Advertise on this site