lkml.org 
[lkml]   [2010]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 2.6.35-rc1] net-next: vmxnet3 fixes [4/5] Do not reset when the device is not opened
    From
    From: Shreyas Bhatewara <sbhatewara@vmware.com>
    Date: Fri, 16 Jul 2010 01:17:29 -0700 (PDT)

    >
    >
    > On Thu, 15 Jul 2010, David Miller wrote:
    >
    >> From: Shreyas Bhatewara <sbhatewara@vmware.com>
    >> Date: Thu, 15 Jul 2010 18:20:52 -0700 (PDT)
    >>
    >> > Is this what you suggest :
    >> >
    >> > ---
    >> >
    >> > Hold rtnl_lock to get the right link state.
    >>
    >> It ought to work, but make sure that it is legal to take the
    >> RTNL semaphore in all contexts in which this code block
    >> might be called.
    >>
    >
    > This code block is called only from the workqueue handler, which runs in
    > process context, so it is legal to take rtnl semaphore.
    > Tested this code by simulating event interrupts (which schedule this
    > code) at considerable frequency while the interface was brought up and
    > down in a loop. Similar stress testing had revealed the bug originally.

    Awesome, please submit this formally. The copy you sent lacked a commit
    message and signoff.


    \
     
     \ /
      Last update: 2010-07-18 01:37    [W:0.019 / U:150.700 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site