Messages in this thread | | | Subject | Re: [PATCH 3/6] autofs/autofs4: move compat_ioctl handling into fs | From | Ian Kent <> | Date | Fri, 16 Jul 2010 12:40:30 +0800 |
| |
On Fri, 2010-07-16 at 02:14 +0200, Frederic Weisbecker wrote: > 2010/7/6 Ian Kent <raven@themaw.net>: > > > > > > On 06/07/2010, at 7:35 PM, Arnd Bergmann <arnd@arndb.de> wrote: > > > >> > >> Well, the only use of the BKL in autofs4 is in the ioctl function. You > >> can probably replace that trivially with a global mutex, but from a quick > >> inspection, even that should not be needed: The only ioctl command in > >> autofs4 that does not already seem to have adequate locking is > >> autofs4_get_set_timeout, which is even easier to change and still harmless > >> if you don't do it at all. > > > > That's right of course. > > > > Even this shouldn't be a problem as it is called by a single instance, per autofs mount, of the daemon only. A fair amount of effort has gone into trying to make the autofs4 module independent of the BKL over time. However I would still rather not do the change concurrently with the ioctl changes. > > > > Ian > > > In any case, can we let you handle this patch for 2.6.36 inclusion?
I think it makes more sense to keep these common patches together so Arnd probably should keep it with his series.
Ian
| |