[lkml]   [2010]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] Stop ARM boards crashing when CUPS is loaded - 2.6.35-rc5
    On 16/07/10 17:23, Milton Miller wrote:
    > On Fri Jul 16 2010 about 05:33:06 EST, Lee Jones wrote:
    >>> The best solution is probably for the parport code to go through a
    >>> modernisation cycle like the serial code did, essentially using
    >>> platform devices to pass the base addresses. This would make the
    >>> driver more portable, and eliminates this problem entirely (because
    >>> platforms which don't have parports won't register the platform device(s)
    >>> necessary for parport to even probe illegal addresses.)
    >> This sounds brilliant - when are you going to start? </kidding>
    > It has a long time ago ...
    > drivers/parport/parport_pc.c calls parport_pc_find_nonpci_ports,
    > which is in asm/parport.h

    I'm not entirely sure what you're trying to say here?

    How does that help with the platformisation of the driver?

    >> In all seriousness, do you think anyone is likely to undertake this
    >> work anytime soon? I am seeing this problem in a distribution which
    >> is due for release in October. I have no problem implementing a config
    >> change in the meantime, but as you say, a more _correct_ and portable
    >> solution should be sought.
    > Why not replace the arm asm/parport.h with asm-generic/parport.h which
    > already has a check for CONFIG_ISA, which appears to only be selected
    > on a few ARM platforms?

    static int __devinit parport_pc_find_isa_ports(int autoirq, int autodma);
    static int __devinit parport_pc_find_nonpci_ports(int autoirq, int autodma)
    #ifdef CONFIG_ISA
    return parport_pc_find_isa_ports(autoirq, autodma);
    return 0;

    That's perfect!

    This would work a treat.

    Surely this #ifdef should be in all the parport.h files which call

     \ /
      Last update: 2010-07-16 18:45    [W:0.022 / U:115.840 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site