lkml.org 
[lkml]   [2010]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 2.6.35-rc1] net-next: vmxnet3 fixes [3/5] Initialize link state at probe time
    From
    From: Shreyas Bhatewara <sbhatewara@vmware.com>
    Date: Thu, 15 Jul 2010 18:20:14 -0700 (PDT)

    >
    > On Wed, 14 Jul 2010, David Miller wrote:
    >
    >> From: Shreyas Bhatewara <sbhatewara@vmware.com>
    >> Date: Tue, 13 Jul 2010 17:48:55 -0700 (PDT)
    >>
    >> >
    >> > Initialize vmxnet3 link state at probe time
    >> >
    >> > This change initializes the state of link at the time when driver is
    >> > loaded. The ethtool output for 'link detected' and 'link speed'
    >> > is thus valid even before the interface is brought up.
    >> >
    >> > Signed-off-by: Shreyas Bhatewara <sbhatewara@vmware.com>
    >>
    >> You should never, ever, call netif_start_queue() on a device which has
    >> not been brought up.
    >>
    >> But that is what this patch is doing.
    >>
    >
    > I do not understand why you say so. vmxnet3_check_link() is called in
    > probe() with affectTxQueue as false. Hence netif_start_queue() will not be
    > called before device is brought up.
    > vmxnet3_check_link() is again called with affectTxQueue as true in
    > vmxnet3_activate_dev() after device was activated.

    Aha, I see how the logic works now.

    But still there is a problem with this patch, please remove the
    driver version bump and resubmit.

    You should only version bump at the last patch in a series.

    Thanks.


    \
     
     \ /
      Last update: 2010-07-16 07:47    [W:0.034 / U:29.544 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site