lkml.org 
[lkml]   [2010]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/7] vmscan: convert direct reclaim tracepoint to DEFINE_EVENT
    On Fri, Jul 16, 2010 at 07:16:05PM +0900, KOSAKI Motohiro wrote:
    >
    > TRACE_EVENT() is a bit old fashion. convert it.
    >

    heh, it's not a question of fashion :). It was defined this way because
    there wasn't a second user that would use the template. I didn't see the
    advantage of creating a template for one user. Your series adds a second
    one so it makes sense to convert.

    > no functionally change.
    >
    > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
    > ---
    > include/trace/events/vmscan.h | 19 +++++++++++++++++--
    > 1 files changed, 17 insertions(+), 2 deletions(-)
    >
    > diff --git a/include/trace/events/vmscan.h b/include/trace/events/vmscan.h
    > index b26daa9..bd749c1 100644
    > --- a/include/trace/events/vmscan.h
    > +++ b/include/trace/events/vmscan.h
    > @@ -68,7 +68,7 @@ TRACE_EVENT(mm_vmscan_wakeup_kswapd,
    > __entry->order)
    > );
    >
    > -TRACE_EVENT(mm_vmscan_direct_reclaim_begin,
    > +DECLARE_EVENT_CLASS(mm_vmscan_direct_reclaim_begin_template,
    >
    > TP_PROTO(int order, int may_writepage, gfp_t gfp_flags),
    >
    > @@ -92,7 +92,15 @@ TRACE_EVENT(mm_vmscan_direct_reclaim_begin,
    > show_gfp_flags(__entry->gfp_flags))
    > );
    >
    > -TRACE_EVENT(mm_vmscan_direct_reclaim_end,
    > +DEFINE_EVENT(mm_vmscan_direct_reclaim_begin_template, mm_vmscan_direct_reclaim_begin,
    > +
    > + TP_PROTO(int order, int may_writepage, gfp_t gfp_flags),
    > +
    > + TP_ARGS(order, may_writepage, gfp_flags)
    > +);

    Over 80 columns there.

    > +
    > +
    > +DECLARE_EVENT_CLASS(mm_vmscan_direct_reclaim_end_template,
    >
    > TP_PROTO(unsigned long nr_reclaimed),
    >
    > @@ -109,6 +117,13 @@ TRACE_EVENT(mm_vmscan_direct_reclaim_end,
    > TP_printk("nr_reclaimed=%lu", __entry->nr_reclaimed)
    > );
    >
    > +DEFINE_EVENT(mm_vmscan_direct_reclaim_end_template, mm_vmscan_direct_reclaim_end,
    > +
    > + TP_PROTO(unsigned long nr_reclaimed),
    > +
    > + TP_ARGS(nr_reclaimed)
    > +);
    > +

    Over 80 columns here too.

    I know I broke it multiple times in my last series because I thought it
    wasn't enforced any more but I got called on it.


    > TRACE_EVENT(mm_vmscan_lru_isolate,
    >
    > TP_PROTO(int order,

    Otherwise, I can't spot a problem.

    Acked-by: Mel Gorman <mel@csn.ul.ie>

    --
    Mel Gorman
    Part-time Phd Student Linux Technology Center
    University of Limerick IBM Dublin Software Lab


    \
     
     \ /
      Last update: 2010-07-16 13:11    [W:0.024 / U:185.108 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site