lkml.org 
[lkml]   [2010]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/8] touchscreen: fix sign bug
    On Thu, Jul 15, 2010 at 10:43:54PM +0400, Kulikov Vasiliy wrote:
    > platform_get_irq_byname() can return negative results, it is not seen to
    > unsigned ts_irq. Make it signed.
    >
    > Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>

    Acked-By: Luotao Fu <l.fu@pengutronix.de>

    > ---
    > drivers/input/touchscreen/stmpe-ts.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touchscreen/stmpe-ts.c
    > index 77f4374..656148e 100644
    > --- a/drivers/input/touchscreen/stmpe-ts.c
    > +++ b/drivers/input/touchscreen/stmpe-ts.c
    > @@ -269,7 +269,7 @@ static int __devinit stmpe_input_probe(struct platform_device *pdev)
    > struct input_dev *idev;
    > struct stmpe_ts_platform_data *ts_pdata = NULL;
    > int ret = 0;
    > - unsigned int ts_irq;
    > + int ts_irq;
    >
    > ts_irq = platform_get_irq_byname(pdev, "FIFO_TH");
    > if (ts_irq < 0)
    > --
    > 1.7.0.4
    >

    Stupid bug. Thanks for catching this.

    cheers
    Luotao Fu

    --
    Pengutronix e.K. | Dipl.-Ing. Luotao Fu |
    Industrial Linux Solutions | http://www.pengutronix.de/ |
    Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
    Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2010-07-15 22:51    [W:0.037 / U:60.980 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site