| Date | Wed, 14 Jul 2010 14:12:31 -0700 | From | Josh Triplett <> | Subject | Re: [PATCH RFC tip/core/rcu 27/30] rcu: apply ->rda changes to rcutree_trace.c |
| |
On Wed, Jul 14, 2010 at 01:10:01PM -0700, Paul E. McKenney wrote: > The print_rcu_pendings() function used the ->rda[] array, so this > commit makes it instead use per_cpu_ptr(). > > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> > --- > kernel/rcutree_trace.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/kernel/rcutree_trace.c b/kernel/rcutree_trace.c > index 36c95b4..458e032 100644 > --- a/kernel/rcutree_trace.c > +++ b/kernel/rcutree_trace.c > @@ -262,7 +262,7 @@ static void print_rcu_pendings(struct seq_file *m, struct rcu_state *rsp) > struct rcu_data *rdp; > > for_each_possible_cpu(cpu) { > - rdp = rsp->rda[cpu]; > + rdp = per_cpu_ptr(rsp->rda, cpu); > if (rdp->beenonline) > print_one_rcu_pending(m, rdp); > }
For the final version of this patchset, this should get squashed into the previous patch, right? Otherwise, the state after the previous patch but before this one won't compile.
- Josh Triplett
|