Messages in this thread |  | | | Date | Wed, 14 Jul 2010 14:07:18 -0700 (PDT) | | Subject | Re: [PATCH 2.6.35-rc1] net-next: vmxnet3 fixes [4/5] Do not reset when the device is not opened | | From | David Miller <> |
| |
From: Shreyas Bhatewara <sbhatewara@vmware.com> Date: Tue, 13 Jul 2010 17:49:52 -0700 (PDT)
> > Do not reset when the device is not opened > > If a reset is scheduled, and the device goes thru close and open, it > may happen that reset and open may run in parallel. > The reset code now bails out if the device is not opened. > > Signed-off-by: Ronghua Zang <ronghua@vmware.com> > Signed-off-by: Matthieu Bucchianeri <matthieu@vmware.com> > Signed-off-by: Shreyas Bhatewara <sbhatewara@vmware.com>
Testing IFF_UP is just making your race hole a little smaller but it isn't fixing the problem.
In fact, there really isn't any legitimate reason for a driver to test the IFF_UP state bit. netif_running() is the correct test, and asynchronous work queue things like resets should synchronize with open/close using the RTNL lock so that your test of netif_running() is a stable one.
|  |