Messages in this thread |  | | | Date | Wed, 14 Jul 2010 10:19:10 -0700 (PDT) | | From | Shreyas Bhatewara <> | | Subject | Re: [Pv-drivers] RFC: Network Plugin Architecture (NPA) for vmxnet3 |
| |
On Wed, 14 Jul 2010, Greg KH wrote:
> On Mon, Jul 12, 2010 at 08:06:28PM -0700, Shreyas Bhatewara wrote: > > drivers/net/vmxnet3/vmxnet3_drv.c | 1845 > > +++++++++++++++++++-------------- > > Your patch is line-wrapped and can not be applied :( > > Care to fix your email client? > > One thing just jumped out at me when glancing at this: > > > +static INLINE void > > +MoveMemory(void *dst, > > + void *src, > > + size_t length) > > +{ > > + size_t i; > > + for (i = 0; i < length; ++i) > > + ((u8 *)dst)[i] = ((u8 *)src)[i]; > > +} > > + > > +static INLINE void > > +ZeroMemory(void *memory, > > + size_t length) > > +{ > > + size_t i; > > + for (i = 0; i < length; ++i) > > + ((u8 *)memory)[i] = 0; > > +} > > Is there some reason that our in-kernel functions that do this type of > logic are not working for you to require you to reimplement this? > > thanks, > > greg k-h >
Greg,
Thanks for pointing out. I will fix both these issues and repost the patch.
->Shreyas
|  |