lkml.org 
[lkml]   [2010]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] CFQ: Don't store left slice when slice used up or for a idle workload
Date
Gui Jianfeng <guijianfeng@cn.fujitsu.com> writes:

> Jeff Moyer wrote:
>> Gui Jianfeng <guijianfeng@cn.fujitsu.com> writes:
>>
>>> It doesn't make sence to store left time slice for an idle workload
>>> or for the cfqq that uses up its slice.
>>
>> Did you actually observe any problems? As I understand it, if you
>> overrun your slice you get a negative offset, so I think we want to keep
>> that.
>
> Hi Jeff
>
> If that's the case, do we also need to store the negative offset when slice
> used up in cfq_select_queue() and cfq_idle_slice_timer()?

Good question; the code is inconsistent as it stands.

/*
* store what was left of this slice, if the queue idled/timed out
*/

If we are to believe that comment, then yes, we should also call
cfq_slice_expired with timed_out set to 1 in cfq_idle_slice_timer when
the slice is used, and for certain cases in select_queue.

I find this counter-intuitive, actually. I would have stored residual
for quite the opposite situation: where you are preempted and so don't
get to run for your fair share. But, there must be some
logic/experience behind the current mechanism....

Cheers,
Jeff


\
 
 \ /
  Last update: 2010-07-14 15:27    [W:0.039 / U:1.908 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site