Messages in this thread | | | Date | Tue, 13 Jul 2010 12:25:39 +0800 | From | Xiao Guangrong <> | Subject | Re: [PATCH v5 6/9] KVM: MMU: introduce pte_prefetch_topup_memory_cache() |
| |
Avi Kivity wrote: > On 07/13/2010 04:16 AM, Xiao Guangrong wrote: >> >> >>> btw, what about dirty logging? will prefetch cause pages to be marked >>> dirty? >>> >>> We may need to instantiate prefetched pages with spte.d=0 and examine it >>> when tearing down the spte. >>> >>> >> Yeah, all speculative path are broken dirty bit tracking, and i guess >> it's >> need more review, so i plan to do it in the separate patch, i'll post >> it after >> this patchset merged, could you allow it? >> >> > > Regressions? no. Or do you mean the problem already exists? Where?
I mean this is a exist problem, likes invlpg, pte-write and sync-page, there are speculative path that it's not real access, but marked dirty if pte is writable.
| |