Messages in this thread |  | | | From | "Nori, Sekhar" <> | | Date | Mon, 12 Jul 2010 16:19:03 +0530 | | Subject | RE: [PATCH 1/2] regulator: tps6507x: allow driver to use DEFDCDC{2,3}_HIGH register |
| |
Hi Mark,
On Mon, Jul 12, 2010 at 16:10:45, Mark Brown wrote: > On Mon, Jul 12, 2010 at 04:04:46PM +0530, Sekhar Nori wrote: > > > + > > + /* Does DCDC high or the low register defines output voltage? */ > > + bool defdcdc_high; > > This should probably be "defdcdc_default" or something. Presumably the > line can also be wired to a GPIO and changed at runtime (otherwise the > feature seems at best odd) and if support for that is implemented then > this will change from being a static configuration in the platform data > to something configured dynamically so the name would no longer make > sense.
Quite right, it should be possible to change that line at runtime - though none of the existing boards use that flexibility. Will change the name as you have suggested.
Thanks, Sekhar
|  |