lkml.org 
[lkml]   [2010]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/2] OCFS2: Allow huge (> 16 TiB) volumes to mount
From
On Mon, Jul 12, 2010 at 6:25 PM, Dave Chinner <david@fromorbit.com> wrote:
>
> The XFS code is different to the above because there is still a 16TB
> size limit on 32 bit systemsi (i.e. page cache address limits). IOWs,
> you can't just remove the above 16TB check unless you (i.e. OCFS2)
> handle >16TB block devices on 32 bit systems correctly...

If you look at my patch, you will see that is precisely what it does.
As the comments indicate, it uses the exact same check as ext4, which
will correctly refuse to mount huge volumes on 32-bit systems.

The XFS test appears to be the same thing written a little
differently. Andreas is suggesting that somebody should factor out
this check into a common library routine. That sounds like a fine
idea, but it also sounds orthogonal to the (simple and useful) patch I
am attempting to submit.
- Pat


\
 
 \ /
  Last update: 2010-07-13 03:39    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site