lkml.org 
[lkml]   [2010]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Dynamic Debug broken on 2.6.35-rc3?


On Mon, 12 Jul 2010, Jason Baron wrote:
...
> I will re-post the above as a separate thread. Also, I should probably
> post a patch to add myself to the MAINTAINERS file, since I didn't see
> Yehuda's patch until now...

Yeah, I wasn't sure who was responsible for this module. Wasn't clear
from the log.

>
>> If Yehuda's patch is fixing this already, we still need it backported for
>> 2.6.34 stable kernel and further?
>>
>
> Yes, patch might need to be adjusted a bit but is still relevant for
> 2.6.34 stable. The situation was exacerbated by:
>
> commit 3bafeb6247042dcbb72b0141ec7c7107de9f0b99
> Author: Linus Torvalds <torvalds@linux-foundation.org>
> Date: Sat Jun 5 11:17:36 2010 -0600
>
> module: move find_module check to end
>
> during the 2.6.35 time frame.
>

Right. Looking at the code, pre .35-rc2 loads the dynamic debug code after
verifying that the module is loadable. So it's a bit harder to hit
it, although it can still fail at the following module_finalize() or at
the parse_args(), so the problem is there.

Yehuda


\
 
 \ /
  Last update: 2010-07-12 23:23    [from the cache]
©2003-2011 Jasper Spaans