lkml.org 
[lkml]   [2010]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Staging: line6: fix leaks in line6_probe()
On Mon, Jul 12, 2010 at 06:47:30PM +0400, Kulikov Vasiliy wrote:
> - if (ret < 0) {
> - line6_destruct(interface);
> - return ret;
> - }
> + if (ret < 0)
> + goto err_put;

This should be:
goto err_destruct;

regards,
dan carpenter

>
> dev_info(&interface->dev, "Line6 %s now attached\n",
> line6->properties->name);
> line6_devices[devnum] = line6;
> line6_list_devices();
> + return 0;
> +
> +err_destruct:
> + line6_destruct(interface);
> +err_put:
> + usb_put_intf(interface);
> + usb_put_dev(usbdev);
> return ret;
> }
>



\
 
 \ /
  Last update: 2010-07-12 18:23    [W:0.036 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site