[lkml]   [2010]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH 1/2] JBD2: Allow feature checks before journal recovery
    Before we start accessing a huge (> 16 TiB) OCFS2 volume, we need to
    confirm that its journal supports 64-bit offsets. So we need to check
    the journal's feature bits before recovering the journal.

    This is not possible with JBD2 at present, because the journal
    superblock (where the feature bits reside) is not loaded from disk until
    the journal is recovered.

    This patch loads the journal superblock in
    jbd2_journal_check_used_features() if it has not already been loaded,
    allowing us to check the feature bits before journal recovery.

    Signed-off-by: Patrick LoPresti <>

    diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
    index bc2ff59..c5a864f 100644
    --- a/fs/jbd2/journal.c
    +++ b/fs/jbd2/journal.c
    @@ -1365,6 +1365,8 @@ int jbd2_journal_check_used_features (journal_t *journal, unsigned long compat,

    if (!compat && !ro && !incompat)
    return 1;
    + if (journal_get_superblock(journal))
    + return 0;
    if (journal->j_format_version == 1)
    return 0;

     \ /
      Last update: 2010-07-11 19:05    [W:0.033 / U:14.544 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site