Messages in this thread | | | Date | Sat, 10 Jul 2010 23:41:56 +0200 | From | Sam Ravnborg <> | Subject | Re: [PATCH] Drivers: isdn: Fixed warnings and odd code. |
| |
On Sat, Jul 10, 2010 at 05:27:29PM -0400, Zachary Richey wrote: > This patch fixes compile time warnings in drivers/isdn/sc/init.c, and > also cleans up what looked like redundant code in this file.
> outb(PRI_BASEPG_VAL, pgport);
Here we request Primary rate interface - see "PRI"
> msleep_interruptible(1000); > - sig = readl(rambase + SIG_OFFSET); > + sig = readl(&rambase + SIG_OFFSET); > pr_debug("Looking for a signature, got 0x%lx\n", sig); > - if(sig == SIGNATURE) > + if (sig == SIGNATURE) > return PRI_BOARD; > - > - /* > - * Try to identify a PRI card > - */ > - outb(BRI_BASEPG_VAL, pgport);
Here we request Basic rate interface - see "BRI".
So this is not redundant code and you cannot delete it.
Sam
| |