lkml.org 
[lkml]   [2010]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Drivers: isdn: Fixed warnings and odd code.
On Sat, Jul 10, 2010 at 05:27:29PM -0400, Zachary Richey wrote:
> This patch fixes compile time warnings in drivers/isdn/sc/init.c, and
> also cleans up what looked like redundant code in this file.


> outb(PRI_BASEPG_VAL, pgport);

Here we request Primary rate interface - see "PRI"

> msleep_interruptible(1000);
> - sig = readl(rambase + SIG_OFFSET);
> + sig = readl(&rambase + SIG_OFFSET);
> pr_debug("Looking for a signature, got 0x%lx\n", sig);
> - if(sig == SIGNATURE)
> + if (sig == SIGNATURE)
> return PRI_BOARD;
> -
> - /*
> - * Try to identify a PRI card
> - */
> - outb(BRI_BASEPG_VAL, pgport);

Here we request Basic rate interface - see "BRI".

So this is not redundant code and you cannot delete it.

Sam


\
 
 \ /
  Last update: 2010-07-10 23:45    [W:0.102 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site