lkml.org 
[lkml]   [2010]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateSat, 10 Jul 2010 14:36:10 -0700
From"H. Peter Anvin" <>
SubjectRe: [PATCH v2] x86: Early-boot serial I/O support
On 07/10/2010 02:32 PM, Cyrill Gorcunov wrote:
>>
>> Yes, but I followed 'isdigit' here for symmetry and it uses 'int'.
>>
>
> ok, I see
>

At the time the code was written, "bool" use in the kernel was still not
really accepted as a matter of style. I think that has changed now and
"bool" is preferred, except as input/output to asm statements (we don't
yet trust gcc to do it sanely across versions.)

As such, changing that would be good, but should be done as a separate
thing.

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.



\
 
 \ /
  Last update: 2010-07-10 23:39    [from the cache]
©2003-2010